How To Submit A Viewer Change

This is not the place to start if you want to change the Viewer; this is one part of the Viewer Integration and Release Processes, and before you belong here, you must have gotten your proposed change accepted (strictly speaking, if you want to do the work of implementing the change first, that's up to you, but you still have to go back and get the idea accepted before you submit the code). See How To Propose A Viewer Feature.

Open Source Quick Links

• How To Propose A Viewer Feature
• How To Submit A Viewer Change
• Integration & Release Processes
• Feedback Portal
• Github

Overview

When you have a change that is ready for integration into the Viewer Development repository, it must be submitted to the Snowstorm Project Team .

Only the Snowstorm Project Team has commit access to the integration repository.

The Second Life Jira system is in the process of being upgraded and reorganized. Until the new system is in place, the process documented on this page will be somewhat less well supported by the tools than we would like. When the new Jira system is ready, Jira workflow will be implemented to make this an easier and more transparent process.

Readiness Criteria

Changes must meet all of the Development Integration Criteria before it can be pulled to the Development repository.

1. Functionality must have been reviewed and accepted by the Product Owner:

   Normally, this means that the item must be on the current Sprint Backlog for the Snowstorm Project Team or some other Linden viewer development team, and has been reviewed by the Product Manager for that team. See How To Propose A Viewer Feature.

2. Design and code must have been reviewed by competent reviewers.

   Reviewer(s) must be identified in the Jira item(s) used to track the change.

3. There must be a test plan

   The test plan must describe in detail how Integration QA can validate the modified behavior.

   • For bug fixes, putting the test plan into a Jira comment is acceptable (since the issue should already contain a documented way to reproduce the problem, this should not be much new work).
   • For features, links to wiki pages are preferred.
   • For features especially, building and distributing a viewer from the Project repository for live testing is strongly encouraged.

4. The Project repository must have merged in the latest changes from Development.

   The results must be validated by building viewers for all platforms and doing at least minimal viewer testing.

5. There must be a Contribution Agreement on file from each contributor to the change that is not a Linden employee or contractor.
   • External contributions must include the appropriate updates to doc/contributions.txt

Submission

Stuff to do: This is a temporary procedure - when the Jira upgrade is completed in early September, this will become Jira workflow in the VWR project

When the above criteria have been met and documented in the Jira issue or issues that track the change:

1. If the issue is not already there, move the issue to the VWR project or create a VWR issue linked to yours.
2. Execute the "Change QA Status" transition (on the left under "Available Workflow Actions")

   

3. Set the status to "Ready To Integrate".

   

4. Assign the issue to "Snowstorm Team"
   • If your account does not have the access required to Assign the issue, send an email to Oz Linden requesting that the issue be assigned.

If there are conflicts between your submission and another ahead of yours in the queue, then you may be asked to pull from Development after the other has been integrated and resolve any conflicts before resubmitting your request. If this happens, your resubmitted request will get a higher priority to try to avoid the same thing happening again.