Code Review Tool - Revision history

Signal Linden at 22:25, 17 November 2022

2022-11-17T22:25:41Z

← Older revision		Revision as of 15:25, 17 November 2022
Line 1:		Line 1:
	{{Project Snowstorm Nav}}		{{Project Snowstorm Nav}}
	At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into ~~Bitbucket~~.		At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into GitHub.

	The content of reviews on that system is available in [http://lecs-opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].		The content of reviews on that system is available in [http://lecs-opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].

Oz Linden: Text replacement - "http://lecs.opensource.secondlife.com/" to "http://lecs-opensource.secondlife.com/"

2017-07-06T21:16:16Z

Text replacement - "http://lecs.opensource.secondlife.com/" to "http://lecs-opensource.secondlife.com/"

← Older revision		Revision as of 14:16, 6 July 2017
Line 2:		Line 2:
	At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into Bitbucket.		At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into Bitbucket.

	The content of reviews on that system is available in [http://lecs.opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].		The content of reviews on that system is available in [http://lecs-opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].

Oz Linden: Replaced content with "{{Project Snowstorm Nav}} At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be …"

2014-03-17T15:16:49Z

Replaced content with "{{Project Snowstorm Nav}} At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be …"

Show changes

Oz Linden: /* Posting Failure */ - corrected command for finding the common ancestor

2012-01-24T19:25:06Z

Posting Failure: - corrected command for finding the common ancestor

← Older revision		Revision as of 12:25, 24 January 2012
Line 85:		Line 85:

	There are two ways to correct this problem; for either method, you must first determine the common base with the repository you are reviewing against. Run the command:		There are two ways to correct this problem; for either method, you must first determine the common base with the repository you are reviewing against. Run the command:
	hg out ''base-repository'' --template '{parents~~\|short~~}' --limit 1		hg out ''base-repository'' --template '{parents}' --limit 1
	This is the ''base-revision'' in the commands below. You can then either:		This is the ''base-revision'' in the commands below. You can then either:
	;Create a single diff file that shows all changes from the base to your current code		;Create a single diff file that shows all changes from the base to your current code

Rand Linden at 20:24, 11 August 2011

2011-08-11T20:24:30Z

← Older revision		Revision as of 13:24, 11 August 2011
Line 1:		Line 1:
	~~{{RightToc}}~~

	:''Given enough eyeballs, all bugs are shallow''		:''Given enough eyeballs, all bugs are shallow''
	:: - [http://en.wikipedia.org/wiki/Linus%27_Law Linus' Law], according to Eric S. Raymond		:: - [http://en.wikipedia.org/wiki/Linus%27_Law Linus' Law], according to Eric S. Raymond
			{{Project Snowstorm Nav}}
			__TOC__
			<br clear="all"/>
	Linden Lab maintains an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at [https://codereview.secondlife.com codereview.secondlife.com] to be used for reviewing any proposed changes to any of our open source projects.		Linden Lab maintains an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at [https://codereview.secondlife.com codereview.secondlife.com] to be used for reviewing any proposed changes to any of our open source projects.

Oz Linden: /* Posting Failure */

2011-06-21T13:46:13Z

Posting Failure

← Older revision		Revision as of 06:46, 21 June 2011
Line 98:		Line 98:
	:Create the diff to be reviewed by:		:Create the diff to be reviewed by:
	hg diff -r "''my-base-revision''" -r tip > ''review.diff''		hg diff -r "''my-base-revision''" -r tip > ''review.diff''
			:The web page for posting a review has a separate upload field for the parent diff; this will allow the ReviewBoard to correctly display your diff without including the parent diff changes in the review.

	==Reviewing==		==Reviewing==

Oz Linden: /* Publish Your Review */

2011-06-21T13:09:08Z

Publish Your Review

← Older revision		Revision as of 06:09, 21 June 2011
Line 75:		Line 75:

	Until you '''Publish''' your review, only you can see it. When you do publish it, a notice is sent to the opensource-dev mailing list (and, optionally to any People whose codereview accounts you have selected).		Until you '''Publish''' your review, only you can see it. When you do publish it, a notice is sent to the opensource-dev mailing list (and, optionally to any People whose codereview accounts you have selected).

			===Posting Failure===

			If you get a message like:

			file "''doc/contributions.txt''" (r''6f971899f351'') could not be found in the repository

			it means that you have posted a review based on a revision that does not appear in the repository. This happens when you have either based your review on a project repository that contains changesets not yet integrated to the repository you are reviewing against, or you have created multiple changesets in your repository, but have not given the tool all of the differences.

			There are two ways to correct this problem; for either method, you must first determine the common base with the repository you are reviewing against. Run the command:
			hg out ''base-repository'' --template '{parents\|short}' --limit 1
			This is the ''base-revision'' in the commands below. You can then either:
			;Create a single diff file that shows all changes from the base to your current code
			:This is the correct approach if all the changes are yours and should be reviewed together. This single diff file is the one you should post for review.
			:To create the single diff:
			hg diff -r "''base-revision''" -r tip > ''file.diff''
			''or''
			;Create two diff files - One of the changes to be reviewed, and another for the preceding changes.
			:If ''my-base-revision'' is the parent revision of those you want reviewed,
			:Create the diff of the changes that are ''not'' part of what you want reviewed (called the "parent diff") by:
			hg diff -r "''base-revision''" -r "''my-base-revision''" > ''parent.diff''
			:Create the diff to be reviewed by:
			hg diff -r "''my-base-revision''" -r tip > ''review.diff''

	==Reviewing==		==Reviewing==

Boroondas Gupte: we use 1.5.2 so link to 1.5 docu rather than 1.0

2011-03-23T17:31:24Z

we use 1.5.2 so link to 1.5 docu rather than 1.0

← Older revision		Revision as of 10:31, 23 March 2011
Line 8:		Line 8:
	Use of this system is limited to developers who have executed a [http://lecs.opensource.secondlife.com/SLVcontribution_agmt.pdf Second Life Viewer Contribution Agreement]. Any changes or comments posted to the tool are Contributions as defined by that Agreement.		Use of this system is limited to developers who have executed a [http://lecs.opensource.secondlife.com/SLVcontribution_agmt.pdf Second Life Viewer Contribution Agreement]. Any changes or comments posted to the tool are Contributions as defined by that Agreement.

	For complete documentation, see [http://www.reviewboard.org/docs/manual/1.0/users/ the ReviewBoard User Manual].		For complete documentation, see [http://www.reviewboard.org/docs/manual/1.5/users/ the ReviewBoard User Manual].

	==Logging In==		==Logging In==
Line 25:		Line 25:
	[[Image:Reviewboard.mydashboard.png]]		[[Image:Reviewboard.mydashboard.png]]

	The Dashboard displays reviews and lets you select the ones of interest to you. See the [http://www.reviewboard.org/docs/manual/1.0/users/navigating/dashboard/ full Dashboard documentation].		The Dashboard displays reviews and lets you select the ones of interest to you. See the [http://www.reviewboard.org/docs/manual/1.5/users/navigating/dashboard/ full Dashboard documentation].

	==Post Code To Be Reviewed==		==Post Code To Be Reviewed==

Boroondas Gupte: /* post-review */ link to documentation

2011-03-23T16:35:49Z

post-review: link to documentation

← Older revision		Revision as of 09:35, 23 March 2011
Line 70:		Line 70:
	===post-review===		===post-review===

	There is a command line tool called ~~'''~~post-review~~'''~~, but it is not very mature and whether or not it works can depend on how you created your mercurial repository. ''I plan to work on improving this asap - Oz''		There is a command line tool called [http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ post-review], but it is not very mature and whether or not it works can depend on how you created your mercurial repository. ''I plan to work on improving this asap - Oz''

	===Publish Your Review===		===Publish Your Review===

Oz Linden: Add more detailed help on reviewing

2011-01-14T15:11:03Z

Add more detailed help on reviewing

@@ Line 76: / Line 76: @@
 Until you '''Publish''' your review, only you can see it.  When you do publish it, a notice is sent to the opensource-dev mailing list (and, optionally to any People whose codereview accounts you have selected).
-==Commenting==
+==Reviewing==
-Whenever possible, comment by selecting lines in the file and entering a comment.  It makes it much more specific than if you post a general comment.
+To see the changes in a review request, select '''View Diff''':