Difference between revisions of "Code Review Tool"

From Second Life Wiki
Jump to navigation Jump to search
m
m
 
(21 intermediate revisions by 4 users not shown)
Line 1: Line 1:
:''Given enough eyeballs, all bugs are shallow''
{{Project Snowstorm Nav}}
:: - [http://en.wikipedia.org/wiki/Linus%27_Law Linus' Law], according to Eric S. Raymond
At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into GitHub.


Linden Lab maintains an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at [https://codereview.secondlife.com codereview.secondlife.com] to be used for reviewing any proposed changes to any of our open source projects.
The content of reviews on that system is available in [http://lecs-opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].
 
Use of this system is limited to developers who have executed a [http://lecs.opensource.secondlife.com/SLVcontribution_agmt.pdf Second Life Viewer Contribution Agreement].  Any changes or comments posted to the tool are Contributions as defined by that Agreement.
 
==Accounts==
 
Access to the system requires that you set up an account, which you can do on your own from the login page, or by going directly to the [https://codereview.secondlife.com/account/register/ account registration page].
 
==How To Use ReviewBoard==
 
Use the command:
 
hg diff -r ''commit''
 
to create a patch that shows your change, and upload that patch on the '''Create A Review''' page.
 
There is a command line tool called '''post-review''', but it is not very mature and whether or not it works can depend on how you created your mercurial repository.   ''I plan to work on improving this asap - Oz''
 
===Commenting===
 
Whenever possible, comment by selecting lines in the file and entering a comment.  It makes it much more specific than if you post a general comment.

Latest revision as of 14:25, 17 November 2022

At one time, Linden Lab maintained an instance of the ReviewBoard code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into GitHub.

The content of reviews on that system is available in this archive.

Retrieved from "https://wiki.secondlife.com/w/index.php?title=Code_Review_Tool&oldid=1212823"