Difference between revisions of "Code Review Tool"

From Second Life Wiki
Jump to navigation Jump to search
m
 
(19 intermediate revisions by 4 users not shown)
Line 1: Line 1:
:''Given enough eyeballs, all bugs are shallow''
{{Project Snowstorm Nav}}
:: - [http://en.wikipedia.org/wiki/Linus%27_Law Linus' Law], according to Eric S. Raymond
At one time, Linden Lab maintained an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into GitHub.


Linden Lab maintains an instance of the [http://www.reviewboard.org/ ReviewBoard] code review tool at [https://codereview.secondlife.com codereview.secondlife.com] to be used for reviewing any proposed changes to any of our open source projects.
The content of reviews on that system is available in [http://lecs-opensource.secondlife.com/codereview.secondlife.com/r/index.html this archive].
 
Use of this system is limited to developers who have executed a [http://lecs.opensource.secondlife.com/SLVcontribution_agmt.pdf Second Life Viewer Contribution Agreement].  Any changes or comments posted to the tool are Contributions as defined by that Agreement.
 
==Accounts==
 
Access to the system requires that you set up an account, which you can do on your own from the login page, or by going directly to the [https://codereview.secondlife.com/account/register/ account registration page].
 
When creating your account, please use the same user id that you use for Jira. 
 
When prompted for an email address, use the same address that you use for the opensource-dev mailing list (if you do not, then the notices of reviews you post and comments you make will not be successfully sent to the list).
 
==Post Code To Be Reviewed==
 
Prepare your change in a local working hg repository.  It will be easier to keep track of outstanding reviews if you commit your change to that repository before posting it for review.
 
Once you have a local copy of the change, there are two ways to post it for review:
* [[#Manual Upload|Manual Upload]] using the web page interface
* [[#post-review|post-review]] command line tool
Either way, you must [[#Publish Your Review|Publish Your Review]]
 
===Manual Upload===
 
To create a patch that shows your change, execute the following command from the top level of your repository:
 
hg diff -r ''commit'' > DIFF
 
where ''commit'' is the revision identifier for your change (if you have not made any new changes, this can just be <tt>tip</tt>).
 
===post-review===
 
There is a command line tool called '''post-review''', but it is not very mature and whether or not it works can depend on how you created your mercurial repository.   ''I plan to work on improving this asap - Oz''
 
===Publish Your Review===
 
 
==Commenting==
 
Whenever possible, comment by selecting lines in the file and entering a comment.  It makes it much more specific than if you post a general comment.

Latest revision as of 14:25, 17 November 2022

At one time, Linden Lab maintained an instance of the ReviewBoard code review tool at codereview.secondlife.com to be used for reviewing proposed changes to any of our open source projects. That system has been retired in favor of using the review features integrated into GitHub.

The content of reviews on that system is available in this archive.

Retrieved from "https://wiki.secondlife.com/w/index.php?title=Code_Review_Tool&oldid=1212823"