Talk:SimpleDialogMenuSystem

List of Changes Made

List of line changes from top to bottom:

• float Timeout= 60; TO float Timeout = 60.0;
  • To make it a true float value.
• giveDialog(key ID, integer pageNum) { TO giveDialog(key ID) {
  • pageNum was declared as a global variable and is not needed as a local in the function.
• llDialog(ID, "Page "+(string)pageNum+"\nChoose one:", buttons, channel_dialog); TO llDialog(ID, "Page "+(string)pageNum+"\n"+msg, buttons, channel_dialog);
  • What is the point in having string msg declared at the top if not using it?
• llSetTimerEvent(0); TO llSetTimerEvent(0.0);
  • To make it a true float value.
• giveDialog(ToucherID, pageNum); TO giveDialog(ToucherID);
  • This refers to the ones in the listen section. As stated above, pageNum was declared as a global variable.
• llListenRemove(listen_id) TO CancelListen();
  • In the timer section. Might as well.

I also moved one line:

• llSetTimerEvent(Timeout);

From touch_start to giveDialog. Reason being, if someone chose the "Next" or "Prev" page, it would give them the dialog again, but would not reset the timer. In other words, if it took someone 50 seconds to decide to push the "Next" page button, they would then only have 10 seconds to choose a button. If they decided to go to the next page again, or go to the previous page, that would leave them even less time. I thought about doing the same for:

• listen_id = llListen( channel_dialog, "", ToucherID, "");

As if someone were to push the "Back" button, it would remove the listen and would have to be declared again if they were redirected to another menu. However, I realized the creator/user of the script may not use the giveDialog function to give them the previous menu, and decided not to change this.

L1ghtsh0wz3n Resident 10:44, 9 November 2013 (PST)

It's got other bugs, if you spam click it, triggering multiple touch_start events, it will leak listens to the point you crash the script. pageNum shouldn't have been made a global, it should have remained a local but the entire design leaves much to be desired and your solution is valid. The script needs to be rewritten. -- Strife ^{(talk|contribs)} 11:28, 9 November 2013 (PST)