Difference between revisions of "Talk:SHA-1"
Jump to navigation
Jump to search
| Line 4: | Line 4: | ||
:I wracked my brains about your code for a long while before doing it.did it for several reasons: | :I wracked my brains about your code for a long while before doing it.did it for several reasons: | ||
:*It's slow and uses | :*It's slow and uses a lot of memory, converting the entire string into a list isn't a good idea. | ||
:*The original version could only handle ASCII-7 text. | :*The original version could only handle ASCII-7 text. | ||
:*A version using UTF8ToUnicodeInteger fail on any Unicode character greater then 0x7FFF (since you didn't do a complete implementation of UTF-16). | :*A version using UTF8ToUnicodeInteger fail on any Unicode character greater then 0x7FFF (since you didn't do a complete implementation of UTF-16). | ||
| Line 14: | Line 14: | ||
:I wanted to keep your name on the code but that presented a license issue. You wrote it almost verbatim from the pseudo-code from Wikipedia, except for the integer-list code. By the time I had rewritten it, it had none of your hallmarks, and only shared bits in common with the Wikipedia articles pseudo-code. Speaking of which I should put that in the header. -- [[User:Strife Onizuka|Strife Onizuka]] 19:13, 24 October 2007 (PDT) | :I wanted to keep your name on the code but that presented a license issue. You wrote it almost verbatim from the pseudo-code from Wikipedia, except for the integer-list code. By the time I had rewritten it, it had none of your hallmarks, and only shared bits in common with the Wikipedia articles pseudo-code. Speaking of which I should put that in the header. -- [[User:Strife Onizuka|Strife Onizuka]] 19:13, 24 October 2007 (PDT) | ||
: | |||
::Okay - that's fine with me, I noticed that yours was very different (not to mention much better). Although, I didn't look at the Wikipedia pseudo-code, I was looking at a Java version of the code and trying to get it to work in LSL ;P. [[User:Xaviar Czervik|Xaviar Czervik]] 15:27, 25 October 2007 (PDT) | |||
Revision as of 15:27, 25 October 2007
Xaviar Czervik's Code?
I - Xaviar Czervik - wrote code for this function and it is no longer here. The function was originally written by me but everything has been replaced. It is even now Copyright Strife Onizuka. I'm not against this - as I'm sure Strife is a better coder than I am - I'd just like to know what happened to my code... Xaviar Czervik 10:18, 22 October 2007 (PDT)
- I wracked my brains about your code for a long while before doing it.did it for several reasons:
- It's slow and uses a lot of memory, converting the entire string into a list isn't a good idea.
- The original version could only handle ASCII-7 text.
- A version using UTF8ToUnicodeInteger fail on any Unicode character greater then 0x7FFF (since you didn't do a complete implementation of UTF-16).
- LSL doesn't use UTF-16, it uses UTF-8; its logical to have a UTF-8 implementation.
- The license link (FDL) didn't match the license granted (GPL).
- A GPLed hashing library isn't useful. Anything that depends upon it becomes infected by the GPL. You couldn't use it with products you gave away.
- The GPL is not compatible with the wiki license and LL has said they will only honor the wiki license.
- The LGPL is compatible with the wiki CC-BY license.
- I wanted to keep your name on the code but that presented a license issue. You wrote it almost verbatim from the pseudo-code from Wikipedia, except for the integer-list code. By the time I had rewritten it, it had none of your hallmarks, and only shared bits in common with the Wikipedia articles pseudo-code. Speaking of which I should put that in the header. -- Strife Onizuka 19:13, 24 October 2007 (PDT)
-
- Okay - that's fine with me, I noticed that yours was very different (not to mention much better). Although, I didn't look at the Wikipedia pseudo-code, I was looking at a Java version of the code and trying to get it to work in LSL ;P. Xaviar Czervik 15:27, 25 October 2007 (PDT)