Difference between revisions of "Snowstorm Daily Scrum Archive"

From Second Life Wiki
Jump to navigation Jump to search
 
(265 intermediate revisions by 3 users not shown)
Line 3: Line 3:
<br clear="all"/>
<br clear="all"/>


== Friday, September 17, 2010 ==
== Sprint 16, ends 05.31.11 ==
 
== Wednesday, May 18 ==
=== General Notes ===
----
* Merge Monkey of the Day:Oz
 


===Team Status===
===Team Status===
----
----
 
==== Oz Linden ====
====Aimee Linden====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* STORM-122 (Clean-up dead code from obsolete floaters)
* Much merging
** Killed around 20 obsolete XUI files, buried about 175 dead files including all the translations.
* Assorted repairs to mesh branch merge
* Took a quick peak at STORM-95
* Reviewing Windlight builds
* STORM-134 (crash in LLViewerObjectList::removeFromLocalIDTable)


<b>FUTURE</b><br />
<b>FUTURE</b><br />
* STORM-134 (crash in LLViewerObjectList::removeFromLocalIDTable)
* Submit storm-1100
* Start on storm-1265


<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
* None.
* none


====Tofu Linden====
==== Wolf Linden ====
----
<i>Not available for Daily Scrum today</i>
 
 
====Oz Linden====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* Merged and built STORM-175 (I think I'll need help testing this, as I have no projectile weapons)
* Assorted Jira and process issues
<b>FUTURE</b><br />
<b>FUTURE</b><br />
* Third party viewer developer meeting
* Working on getting an answer for Storm-565
* Find or create an issue for new water display problem on Mac


<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
* none
* none


====Merov Linden====
==== Grumpity ProductEngine ====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* Merge Monkey duties
* crashhunters
* STORM-168 : Python cleanup : in merov_linden/viewer-development-importer
* sprint cleanup
* STORM-161 : Hide highlight when editing : in merov_linden/viewer-development-features
* some triage
 
<b>FUTURE</b><br />
* STORM-104 (VWR-22761) : LLKDU upgrade. More on perf tracking while waiting for license to clear and new version to come.
* STORM-162
 
<b>IMPEDIMENTS</b><br />
* Kakadu license upgrade
 
 
====Q Linden====
----
<b>PAST</b><br />
* STORM-143 functionality finished but blocked by "broken glass"
* Some meetings on release process and other topics
* Medical
 
<b>FUTURE</b><br />
* Write new STORM issue to fix broken file glob function in LLDIR and write tests for it
* Work on getting a build into beta
 
<b>IMPEDIMENTS</b><br />
* Ugly source code for LLDIR
 
 
====Esbee Linden====
----
<b>PAST</b><br />
* OOO
 
<b>FUTURE</b><br />
<b>FUTURE</b><br />
* OOO Today (Maybe)
* crashhunters cleanup
* Modify process for sending Viewer ideas/feature requests
* VWR triage
* VWR triage
* Backlog grooming & new feature request review
* STORM-951
* Write UI customization blog post.
* PO build
* Write end of Sprint 3 wrap-up blog post
* reports
   
   
<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
* Shipping companies
* none


 
==== Vadim ProductEngine ====
====Paul ProductEngine ====
----
<i>OOO- vacation</i>
 
 
====Andrew ProductEngine====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* Revived debugger
* Reported a crash in viewer-development.
* Major bug STORM-177 ([I18N] [DATETIME] Garbled letters for Date that used to be hard-coded (Japanese)).
* Manual merge from viewer-development to the WLRS integration branch.
* Showstopper bug STORM-180 (Viewer crashes on login in Japanese locale).
* WLRS repo Windows build issues: fixed one and handed another over to Paul.
** Fixed both with one changeset and sent for integration.
* Task STORM-1256 (Region environment settings editor):
*Removed unused code and xml data from statusbar.
** WIP. Investigating time synchronization between viewer and region.
* Bug STORM-107 ([I18N] [CORRUPTED CHAR IN DATE] Polish character corruption in date)
** Fixed and sent for integration.
* Major bug STORM-153 ([HARDCODE] Conference and non-existent IM session name strings are hardcoded)
** Started changing according to yesterday's discussion with Vadim. Estimate- 2 hours.
 
<b>FUTURE</b><br />
<b>FUTURE</b><br />
* Finish STORM-153 ([HARDCODE] Conference and non-existent IM session name strings are hardcoded).
* Continue with STORM-1256.
* Bug STORM-188 (Viewer crashes while intensive flying forward/backward).
* Bug STORM-187 (Opening the sidebar shrinks a wide chat text window, but closing doesn't restore it).


<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
* none
* none


 
==== Andrey ProductEngine ====
====Vadim ProductEngine====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* Bug STORM-183 (Wear button is disabled when outfit1 is subset of outfit2):

* picked up 2.6.9 beta build r230161
** Fixed.
* verified yestarday's blockers - crash and help unavailability
* Bug STORM-186 ("Take Off - Remove from current outfit" menu items from gear/context menu should behave in the same way):

* passed smoke & integrity tests, refer to the IQA-164 for more details
** Fixed.
* tested changes in scope of IQA-166, there is a bunch TPE cannot test. IQA-166 re-assigned back to Martin
* Bug STORM-185 (Edit Outfit panel: do not scroll worn items' list to the bottom after add/replace):

 
** Fixed.
* Bug STORM-184 (Save is enabled for outfits consisting of original items):
** 
Could not reproduce.
* Grabbed a few bugs for PE to work on during sprint 4.
   
<b>FUTURE</b><br />
<b>FUTURE</b><br />
* Bug STORM-191 ('(???)(???)' instead object's name is shown  in Block list if block just created object from Nearby chat).
* pickup latest v-d build?
** ETA: 3h.
* Bug STORM-192 (Ctrl-Shift-W hides all chat until a viewer restart).
** ETA: 1d.


<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
* none
* none


 
==== Wolfpup Lowenhar ====
====Seth ProductEngine (Sergey)====
----
----
<b>PAST</b><br />
<b>PAST</b><br />
* BUG (STORM-154) Group Call button label is cut after resizing undocked Group Profile panel
* Working inworld(this is part of testing localy built viewers).
** Fixed.
** Checking on horses and bundles, plus work on note cards for them.
* BUG (STORM-156) "Add friend" button is cut in People Profile
* Deciding on what type of build to work on next.
** Fixed.
* Run a Test build of Brad's must build faster Repository as a test on local system.
** Test Build took 8 minutes longer than normal and there was loss of functionality in most of the side panles.
* Local build after mesh code merge crashes on start.
** This could be a merge issue that is causing the viewer to error in LLViewerTextureList::addImageToList: ASSERT (mInitialized).
** also looks to be same issue i had on linux testing the gpu viewer from storm-1100 .


<b>FUTURE</b><br />
<b>FUTURE</b><br />
* BUG (STORM-159) UI: Allow item drop onto profiles
* Working inworld(this is part of testing localy built viewers).
Estimated: 8 hours
* Wait for crash on error to be fixed.


<b>IMPEDIMENTS</b><br />
<b>IMPEDIMENTS</b><br />
*none
* Getting Autobuild system and security software to play nicely on my system.


= Past Updates =
<b>May</b><br />
[[Snowstorm_Daily_Scrum_Archive/05172011 | 17]] | [[Snowstorm_Daily_Scrum_Archive/05162011 | 16]] | [[Snowstorm_Daily_Scrum_Archive/05132011 | 13]] | [[Snowstorm_Daily_Scrum_Archive/05122011 | 12]] | [[Snowstorm_Daily_Scrum_Archive/05112011 | 11]] | [[Snowstorm_Daily_Scrum_Archive/05052011 | 05]] | [[Snowstorm_Daily_Scrum_Archive/05042011 | 04]]


====Andrey ProductEngine====
<b>April</b><br />
----
[[Snowstorm_Daily_Scrum_Archive/04272011 | 27]] | [[Snowstorm_Daily_Scrum_Archive/04262011 | 26]] | [[Snowstorm_Daily_Scrum_Archive/04252011 | 25]] | [[Snowstorm_Daily_Scrum_Archive/04142011 | 14]] | [[Snowstorm_Daily_Scrum_Archive/04132011 | 13]] | [[Snowstorm_Daily_Scrum_Archive/04122011 | 12]] | [[Snowstorm_Daily_Scrum_Archive/04072011 | 07]] | [[Snowstorm_Daily_Scrum_Archive/04062011 | 06]]
<b>PAST</b><br />
* smoke and integrity tests against r209678, see already shared spreadsheet
* resolved tickets verification
 
<b>FUTURE</b><br />
* regression & functional testing of r209678 in scope changes since r209322
* complete verification of tickets integrated into r209678


<b>IMPEDIMENTS</b>
<b>March</b><br />
* none
[[Snowstorm_Daily_Scrum_Archive/03312011 | 31]] | [[Snowstorm_Daily_Scrum_Archive/03302011 | 30]] | [[Snowstorm_Daily_Scrum_Archive/03292011 | 29]] | [[Snowstorm_Daily_Scrum_Archive/03192011 | 19]] | [[Snowstorm_Daily_Scrum_Archive/03182011 | 18]] | [[Snowstorm_Daily_Scrum_Archive/03172011 | 17]] | [[Snowstorm_Daily_Scrum_Archive/03162011 | 16]] | [[Snowstorm_Daily_Scrum_Archive/03152011 | 15]] | [[Snowstorm_Daily_Scrum_Archive/03142011 | 14]] | [[Snowstorm_Daily_Scrum_Archive/03112011 | 11]] | [[Snowstorm_Daily_Scrum_Archive/03102011 | 10]] | [[Snowstorm_Daily_Scrum_Archive/03092011 | 09]] | [[Snowstorm_Daily_Scrum_Archive/03082011 | 08]] | [[Snowstorm_Daily_Scrum_Archive/03072011 | 07]] | [[Snowstorm_Daily_Scrum_Archive/03042011 | 04]] | [[Snowstorm_Daily_Scrum_Archive/03032011 | 03]] | [[Snowstorm_Daily_Scrum_Archive/03022011 | 02]] | [[Snowstorm_Daily_Scrum_Archive/03012011 | 01]]


<b>February</b><br />
[[Snowstorm_Daily_Scrum_Archive/02282011 | 28]] | [[Snowstorm_Daily_Scrum_Archive/02252011 | 25]] | [[Snowstorm_Daily_Scrum_Archive/02242011 | 24]] | [[Snowstorm_Daily_Scrum_Archive/02232011 | 23]] | [[Snowstorm_Daily_Scrum_Archive/02222011 | 22]] | [[Snowstorm_Daily_Scrum_Archive/02182011 | 18]] | [[Snowstorm_Daily_Scrum_Archive/02162011 | 16]] | [[Snowstorm_Daily_Scrum_Archive/02152011 | 15]] | [[Snowstorm_Daily_Scrum_Archive/02142011 | 14]] | [[Snowstorm_Daily_Scrum_Archive/02112011 | 11]] | [[Snowstorm_Daily_Scrum_Archive/02102011 | 10]] | [[Snowstorm_Daily_Scrum_Archive/02092011 | 09]] | [[Snowstorm_Daily_Scrum_Archive/02082011 | 08]] | [[Snowstorm_Daily_Scrum_Archive/02072011 | 07]] | [[Snowstorm_Daily_Scrum_Archive/02042011 | 04]] | [[Snowstorm_Daily_Scrum_Archive/02032011 | 03]] | [[Snowstorm_Daily_Scrum_Archive/02022011 | 02]] | [[Snowstorm_Daily_Scrum_Archive/02012011 | 01]] |


====Grumpity ProductEngine (Anya)====
<b>January</b><br />
----
[[Snowstorm_Daily_Scrum_Archive/01312011 | 31]] | [[Snowstorm_Daily_Scrum_Archive/01282011 | 28]] | [[Snowstorm_Daily_Scrum_Archive/01272011 | 27]] | [[Snowstorm_Daily_Scrum_Archive/01262011 | 26]] | [[Snowstorm_Daily_Scrum_Archive/01252011 | 25]] | [[Snowstorm_Daily_Scrum_Archive/01242011 | 24]] | [[Snowstorm_Daily_Scrum_Archive/01212011 | 21]] | [[Snowstorm_Daily_Scrum_Archive/01202011 | 20]] | [[Snowstorm_Daily_Scrum_Archive/01192011 | 19]] | [[Snowstorm_Daily_Scrum_Archive/01182011 | 18]] | [[Snowstorm_Daily_Scrum_Archive/01142011 | 14]] | [[Snowstorm_Daily_Scrum_Archive/01132011 | 13]] | [[Snowstorm_Daily_Scrum_Archive/01122011 | 12]] | [[Snowstorm_Daily_Scrum_Archive/01112011 | 11]] | [[Snowstorm_Daily_Scrum_Archive/01102011 | 10]] | [[Snowstorm_Daily_Scrum_Archive/01062011 | 06]] | [[Snowstorm_Daily_Scrum_Archive/01062011 | 06]] | [[Snowstorm_Daily_Scrum_Archive/01052011 | 05]] | [[Snowstorm_Daily_Scrum_Archive/01042011 | 04]]
<b>PAST</b><br />
*jira wrangling some more
** no way to win with "Approved by"
** issues with incorrect status - fixed
* request additional feature work for PE
* meetings
* reports


<b>FUTURE</b><br />
<b>2010</b><br />
* crashhunters
<b>December</b><br />
* More jira:
[[Snowstorm_Daily_Scrum_Archive/12302010 | 30]] | [[Snowstorm_Daily_Scrum_Archive/12232010 | 23]] | [[Snowstorm_Daily_Scrum_Archive/12222010 | 22]] | [[Snowstorm_Daily_Scrum_Archive/12212010 | 21]] | [[Snowstorm_Daily_Scrum_Archive/12202010 | 20]] | [[Snowstorm_Daily_Scrum_Archive/12172010 | 17]] | [[Snowstorm_Daily_Scrum_Archive/12162010 | 16]] | [[Snowstorm_Daily_Scrum_Archive/12152010 | 15]] | [[Snowstorm_Daily_Scrum_Archive/12142010 | 14]] | [[Snowstorm_Daily_Scrum_Archive/12132010 | 13]] | [[Snowstorm_Daily_Scrum_Archive/12102010 | 10]] | [[Snowstorm_Daily_Scrum_Archive/12092010 | 09]] | [[Snowstorm_Daily_Scrum_Archive/12082010 | 08]] | [[Snowstorm_Daily_Scrum_Archive/12072010 | 07]] | [[Snowstorm_Daily_Scrum_Archive/12062010 | 06]] | [[Snowstorm_Daily_Scrum_Archive/12032010 | 03]] | [[Snowstorm_Daily_Scrum_Archive/12022010 | 02]] | [[Snowstorm_Daily_Scrum_Archive/12012010 | 01]]
** figure out how to indicate code review status in jira (esbee/oz/sue)
** Streamline Reject workflow: when you Reject a fix, the ticket doesn't get assigned back to the  fixer, nor are you allowed to select assignee. You have to reassign the  ticket manually afterwards.
** get permissions for changing incorrect status/resolution


<b>IMPEDIMENTS</b><br />
<b>November</b><br />  
* None
[[Snowstorm_Daily_Scrum_Archive/11302010 | 30]] | [[Snowstorm_Daily_Scrum_Archive/11292010 | 29]] | [[Snowstorm_Daily_Scrum_Archive/11242010 | 24]] | [[Snowstorm_Daily_Scrum_Archive/11232010 | 23]] | [[Snowstorm_Daily_Scrum_Archive/11222010 | 22]] | [[Snowstorm_Daily_Scrum_Archive/11192010 | 19]] | [[Snowstorm_Daily_Scrum_Archive/11182010 | 18]] | [[Snowstorm_Daily_Scrum_Archive/11172010 | 17]] | [[Snowstorm_Daily_Scrum_Archive/11162010 | 16]] | [[Snowstorm_Daily_Scrum_Archive/11152010 | 15]] | [[Snowstorm_Daily_Scrum_Archive/11122010 | 12]] | [[Snowstorm_Daily_Scrum_Archive/11112010 | 11]] | [[Snowstorm_Daily_Scrum_Archive/11102010 | 10]] | [[Snowstorm_Daily_Scrum_Archive/11092010 | 09]] | [[Snowstorm_Daily_Scrum_Archive/11082010 | 08]] | [[Snowstorm_Daily_Scrum_Archive/11052010 | 05]] | [[Snowstorm_Daily_Scrum_Archive/11042010 | 04]] | [[Snowstorm_Daily_Scrum_Archive/11032010 | 03]] | [[Snowstorm_Daily_Scrum_Archive/11022010 | 02]] | [[Snowstorm_Daily_Scrum_Archive/11012010 | 01]]


<b>October</b><br />
[[Snowstorm_Daily_Scrum_Archive/10292010 | 29]] | [[Snowstorm_Daily_Scrum_Archive/10282010 | 28]] | [[Snowstorm_Daily_Scrum_Archive/10272010 | 27]] | [[Snowstorm_Daily_Scrum_Archive/10262010 | 26]] | [[Snowstorm_Daily_Scrum_Archive/10252010 | 25]] | [[Snowstorm_Daily_Scrum_Archive/10222010 | 22]] | [[Snowstorm_Daily_Scrum_Archive/10212010 | 21]] | [[Snowstorm_Daily_Scrum_Archive/10202010 | 20]] | [[Snowstorm_Daily_Scrum_Archive/10182010 | 18]] | [[Snowstorm_Daily_Scrum_Archive/10152010 | 15]] | [[Snowstorm_Daily_Scrum_Archive/10142010 | 14]] | [[Snowstorm_Daily_Scrum_Archive/10132010 | 13]] | [[Snowstorm_Daily_Scrum_Archive/10122010 | 12]] | [[Snowstorm_Daily_Scrum_Archive/10112010 | 11]] | [[Snowstorm_Daily_Scrum_Archive/10082010 | 08]] | [[Snowstorm_Daily_Scrum_Archive/10072010 | 07]] | [[Snowstorm_Daily_Scrum_Archive/10062010 | 06]] | [[Snowstorm_Daily_Scrum_Archive/10052010 | 05]] | [[Snowstorm_Daily_Scrum_Archive/10042010 | 04]] | [[Snowstorm_Daily_Scrum_Archive/10012010 | 01]]


== Past Updates ==
<b>September</b><br />
<b>September</b><br />
[[Snowstorm_Daily_Scrum_Archive/09172010 | 17]] | [[Snowstorm_Daily_Scrum_Archive/09162010 | 16]] | [[Snowstorm_Daily_Scrum_Archive/09152010 | 15]] |  
[[Snowstorm_Daily_Scrum_Archive/09272010 | 27]] | [[Snowstorm_Daily_Scrum_Archive/09242010 | 24]] |
[[Snowstorm_Daily_Scrum_Archive/09142010 | 14]] | [[Snowstorm_Daily_Scrum_Archive/09132010 | 13]] | [[Snowstorm_Daily_Scrum_Archive/09092010 | 9]] |  [[Snowstorm_Daily_Scrum_Archive/09082010 | 8]] | [[Snowstorm_Daily_Scrum_Archive/09072010 | 7]] | [[Snowstorm_Daily_Scrum_Archive/09032010 | 3]] |  
[[Snowstorm_Daily_Scrum_Archive/09212010 | 21]] | [[Snowstorm_Daily_Scrum_Archive/09202010 | 20]] | [[Snowstorm_Daily_Scrum_Archive/09172010 | 17]] | [[Snowstorm_Daily_Scrum_Archive/09162010 | 16]] | [[Snowstorm_Daily_Scrum_Archive/09152010 | 15]] | [[Snowstorm_Daily_Scrum_Archive/09142010 | 14]] | [[Snowstorm_Daily_Scrum_Archive/09132010 | 13]] | [[Snowstorm_Daily_Scrum_Archive/09092010 | 09]] |   
[[Snowstorm_Daily_Scrum_Archive/09022010 | 2]] | [[Snowstorm_Daily_Scrum_Archive/09012010 | 1]]
[[Snowstorm_Daily_Scrum_Archive/09082010 | 08]] | [[Snowstorm_Daily_Scrum_Archive/09072010 | 07]] | [[Snowstorm_Daily_Scrum_Archive/09032010 | 03]] | [[Snowstorm_Daily_Scrum_Archive/09022010 | 02]] |  
[[Snowstorm_Daily_Scrum_Archive/09012010 | 01]]


<b>August</b><br />
<b>August</b><br />

Latest revision as of 01:23, 19 May 2011


Sprint 16, ends 05.31.11

Wednesday, May 18

Team Status


Oz Linden


PAST

  • Much merging
  • Assorted repairs to mesh branch merge
  • Reviewing Windlight builds

FUTURE

  • Submit storm-1100
  • Start on storm-1265

IMPEDIMENTS

  • none

Wolf Linden


PAST
FUTURE

  • Working on getting an answer for Storm-565

IMPEDIMENTS

  • none

Grumpity ProductEngine


PAST

  • crashhunters
  • sprint cleanup
  • some triage

FUTURE

  • crashhunters cleanup
  • VWR triage
  • STORM-951
  • PO build
  • reports

IMPEDIMENTS

  • none

Vadim ProductEngine


PAST

  • Reported a crash in viewer-development.
  • Manual merge from viewer-development to the WLRS integration branch.
  • WLRS repo Windows build issues: fixed one and handed another over to Paul.
  • Task STORM-1256 (Region environment settings editor):
    • WIP. Investigating time synchronization between viewer and region.

FUTURE

  • Continue with STORM-1256.

IMPEDIMENTS

  • none

Andrey ProductEngine


PAST

  • picked up 2.6.9 beta build r230161
  • verified yestarday's blockers - crash and help unavailability
  • passed smoke & integrity tests, refer to the IQA-164 for more details
  • tested changes in scope of IQA-166, there is a bunch TPE cannot test. IQA-166 re-assigned back to Martin

FUTURE

  • pickup latest v-d build?

IMPEDIMENTS

  • none

Wolfpup Lowenhar


PAST

  • Working inworld(this is part of testing localy built viewers).
    • Checking on horses and bundles, plus work on note cards for them.
  • Deciding on what type of build to work on next.
  • Run a Test build of Brad's must build faster Repository as a test on local system.
    • Test Build took 8 minutes longer than normal and there was loss of functionality in most of the side panles.
  • Local build after mesh code merge crashes on start.
    • This could be a merge issue that is causing the viewer to error in LLViewerTextureList::addImageToList: ASSERT (mInitialized).
    • also looks to be same issue i had on linux testing the gpu viewer from storm-1100 .

FUTURE

  • Working inworld(this is part of testing localy built viewers).
  • Wait for crash on error to be fixed.

IMPEDIMENTS

  • Getting Autobuild system and security software to play nicely on my system.

Past Updates

May
17 | 16 | 13 | 12 | 11 | 05 | 04

April
27 | 26 | 25 | 14 | 13 | 12 | 07 | 06

March
31 | 30 | 29 | 19 | 18 | 17 | 16 | 15 | 14 | 11 | 10 | 09 | 08 | 07 | 04 | 03 | 02 | 01

February
28 | 25 | 24 | 23 | 22 | 18 | 16 | 15 | 14 | 11 | 10 | 09 | 08 | 07 | 04 | 03 | 02 | 01 |

January
31 | 28 | 27 | 26 | 25 | 24 | 21 | 20 | 19 | 18 | 14 | 13 | 12 | 11 | 10 | 06 | 06 | 05 | 04

2010
December
30 | 23 | 22 | 21 | 20 | 17 | 16 | 15 | 14 | 13 | 10 | 09 | 08 | 07 | 06 | 03 | 02 | 01

November
30 | 29 | 24 | 23 | 22 | 19 | 18 | 17 | 16 | 15 | 12 | 11 | 10 | 09 | 08 | 05 | 04 | 03 | 02 | 01

October
29 | 28 | 27 | 26 | 25 | 22 | 21 | 20 | 18 | 15 | 14 | 13 | 12 | 11 | 08 | 07 | 06 | 05 | 04 | 01

September
27 | 24 | 21 | 20 | 17 | 16 | 15 | 14 | 13 | 09 | 08 | 07 | 03 | 02 | 01

August
30 | 26 | 25 | 24 | 23 | 20 | 19 | 18 | 16